Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MiB ZKAP #137

Merged
merged 3 commits into from
May 1, 2020
Merged

MiB ZKAP #137

merged 3 commits into from
May 1, 2020

Conversation

exarkun
Copy link
Collaborator

@exarkun exarkun commented May 1, 2020

Fixes #136

This removes almost all uses of the global value.  All that remains is its use
as a default in case no configuration is given.
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #137 into master will increase coverage by 0.05%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   91.14%   91.20%   +0.05%     
==========================================
  Files          38       39       +1     
  Lines        2790     2807      +17     
  Branches      360      360              
==========================================
+ Hits         2543     2560      +17     
  Misses        205      205              
  Partials       42       42              
Impacted Files Coverage Δ
src/_zkapauthorizer/tests/test_plugin.py 100.00% <ø> (ø)
src/_zkapauthorizer/tests/test_storage_server.py 28.44% <33.33%> (+0.66%) ⬆️
src/_zkapauthorizer/validators.py 70.00% <70.00%> (ø)
src/_zkapauthorizer/_plugin.py 88.88% <100.00%> (+0.25%) ⬆️
src/_zkapauthorizer/_storage_client.py 96.55% <100.00%> (+0.06%) ⬆️
src/_zkapauthorizer/_storage_server.py 87.19% <100.00%> (+0.07%) ⬆️
src/_zkapauthorizer/model.py 93.38% <100.00%> (+1.81%) ⬆️
src/_zkapauthorizer/storage_common.py 94.00% <100.00%> (+0.97%) ⬆️
src/_zkapauthorizer/tests/test_client_resource.py 98.85% <100.00%> (ø)
src/_zkapauthorizer/tests/test_model.py 89.11% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0fe76...bac0317. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The value of a ZKAP is too low
1 participant