Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional read more and minor changes #39

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

Ameya02
Copy link
Collaborator

@Ameya02 Ameya02 commented Jul 6, 2023

Major Bug Fixed

  1. Readmore button will only display for the card which have more content than the card size.

Minor Bug Fixed

  1. Github Repository will open in a new tab when clicked on button
  2. Github Icon will turn green when hovered in dark mode
  3. Added Tooltip to the Github Button and Toggle Button

@vercel
Copy link

vercel bot commented Jul 6, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @PriyansuMaurya on Vercel.

@PriyansuMaurya first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Ameya02! 🎉 Thank you for submitting your first pull request. Your contribution is extremely valuable, and we are grateful for your dedication to improving our project. We recognize your hard work and commitment. Keep up the excellent job!

We will promptly review your changes and provide helpful feedback. Please remember to review our contributing guidelines. Thank you again for your contributions!

@vercel
Copy link

vercel bot commented Jul 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aifusion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2023 7:03am

<button onClick={() => handleThemeSwitch()}>
{theme === "dark" ? (
<BsToggleOn size={30} />
<BsToggleOn title="White mode" size={30} />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be Light mode

@PriyansuMaurya
Copy link
Owner

Rename the title to "Conditional read more and minor changes"

@Ameya02 Ameya02 changed the title Major and Minor bugs fixes Conditional read more and minor changes Jul 6, 2023
@PriyansuMaurya PriyansuMaurya merged commit 308b6f5 into PriyansuMaurya:main Jul 6, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants