-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sub-domain not used in header #67
Comments
The problem seems to be the following code in Exchange.DkimSigner\DkimSigningRoutingAgent.cs Beyond the sub-domain matching, it appears it would also match abc.net.example.com to abc.net which would be very wrong. As far as I can tell, the domain list isn't sorted, so as a feature it won't necessarily pick the domain closest to the root domain of a sub-domain. It will pick the last domain in the list with a partial match. What is the reason for using Contains()? Can == not be used?
... Also, this code doesn't change with each loop interation, so it can be moved above the forech statement.
|
Thanks for your issue report.
should be changed to
and the FromAddress check shoud be out of the loop. Currently I don't have access to my workstation. I'll fix this when I'm back in one to two weeks. |
Thanks for taking a look and thanks in advance for the fix. |
@Pro: We should provide a new release before close a issue. |
Do you have an ETA for a new release? |
It's good coding practice to close an issue as soon it is fixed within the code rather then closing it after the modified code is released. The Issue Milestone feature can be used to keep track if the issue is already integrated into a release or not. @gogglespisano I'll do some test and then release a version including this bugfix today or in the next few days |
@gogglespisano today I released version 2.1.0 which fixes this issue. |
I had problems installing 2.1.2. I was upgrading from 2.0.3. It failed during the zip extraction because of file in use. This happening using the GUI update or downloading and installing from the downloaded files. I had to disable the signer, then upgrade, then enable the signer. |
Hm, this looks like the MSExchangeTransport wasn't stopped properly. (For the next time please open a new issue instead of replying to an old one, this makes it easier to keep track of different issues, thanks :) ) |
I entered a new issue for it. The good news is my email is now verifying with the correct domain name ☺ Thanks, From: Stefan Profanter [mailto:notifications@github.com] Hm, this looks like the MSExchangeTransport wasn't stopped properly. (For the next time please open a new issue instead of replying to an old one, this makes it easier to keep track of different issues, thanks :) ) — |
I've configured example.com and sub,example.com. Both have all the required dns keys (working on a previous version).
When I send mail from user@sub.example.com the header has d=example.com, not d=sub.example.com. The earlier version sent d=sub.example.com. I've tried change between simple and relaxed with no change.
is this a bug, or a new configuration setting I've missed?
Thanks,
-Stuart
The text was updated successfully, but these errors were encountered: