Migrate extended Euclidean algorithm #202
Conversation
|
@alxmjo Please rebase this with the latest changes from |
Refactor greatest common denominator algorithm to use a header file. Add test cases as .cpp file to test. Also fix an error in greatest common denominator function that prevented the accurate calculation of negative arguments. Update README.
Removes old .cpp file for the extended Euclidean algorithm and adds unit tests. Also updates README.
alxmjo
force-pushed
the
reorganise-extendedeuclidean
branch
from
a523c68
to
11cce22
Compare
|
@faheel Not sure why this ended up bringing in the older version of the greatest common divisor files. This is what it looks like for me locally: alxmjo@11cce22 |
|
I think it's OK now. Apologies for the mixup. |
|
Can anyone please specify the work/issue at hand? I would like to start working on it. |
|
@ankur54 This is closed and no work needs to be done. I just shared it as a reference for how to go about refactoring the code into header files. |
|
ok! So what about Lowest common ancestor in Binary Search tree? Is it also completed? |
|
If you see it in the |
|
I'm sorry, but I can't find any such file. So I assume its still not resolved. In that case, I would like to work on it. |
|
No problem, I just didn't take the time to check myself. 🙂Please do. But start an issue for it first so that others know that it's being implemented. |
Migrate extended Euclidean algorithm to header file (as described in #163).