Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data conversion #396

Closed
wants to merge 4 commits into from
Closed

Data conversion #396

wants to merge 4 commits into from

Conversation

0xWaleed
Copy link

@0xWaleed 0xWaleed commented Dec 14, 2020

Implementation of data conversion from upper case to lower case and vice versa using
bits manipulation and wrote tests for all possible cases.
Both functions takes const ref to avoid copying and construct a local string variable
then return it with implicit move semantic without changing the input.
I did all my best to comply with the guidelines.

I am open to any change requests on this PR and please detail the changes with reasons so I can learn. 馃グ

Thanks.

Closes #99

- Make upper case using bit manipulation with unit tests
- Make lower case using bit manipulation with unit tests
@0xWaleed
Copy link
Author

@faheel @alxmjo sorry for the mention, it took me some time to do this just for contribution and I would love to hear a feedback from you. I know you are busy and excuse me for this. 馃槉

@stale
Copy link

stale bot commented Apr 18, 2021

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Inactive label Apr 18, 2021
@0xWaleed
Copy link
Author

@faheel Sorry is supposed to be discarded ?

@0xWaleed
Copy link
Author

Not worth my time. should be archived if not maintained. Thanks @faheel , @alxmjo

@0xWaleed 0xWaleed closed this Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement data validation
2 participants