Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThunderClock driver update needed for 2024+ #72

Closed
inexorabletash opened this issue Sep 22, 2023 · 2 comments
Closed

ThunderClock driver update needed for 2024+ #72

inexorabletash opened this issue Sep 22, 2023 · 2 comments

Comments

@inexorabletash
Copy link

inexorabletash commented Sep 22, 2023

The ThunderClock system clock card provides day, month and day-of-week but not year. From those, the ProDOS driver infers the year using a table. But the table only handles a range of 6 or 7 years.

If I recall correctly, the updated table in ProDOS 2.4.2 expires after 2023, so as of 1/1/2024 users will start seeing incorrect dates in ProDOS, if they're using the ThunderClock or compatibles.

This doesn't affect drivers for clocks that have the year (e.g. the built in IIgs clock driver, third party No-Slot-Clock driver, etc) so it's not a huge deal.

@inexorabletash
Copy link
Author

I just double checked and... yeah, 2.4.2 has this table:

For 2018 - 2023: $12, $17, $16, $15, $14, $14, $13

If it helps, one of the following tables could be patched in:

For 2023 - 2028: $18, $17, $1C, $1B, $1A, $19, $18
For 2024 - 2028: $18, $1C, $1C, $1B, $1A, $19, $18

inexorabletash added a commit to a2stuff/prodos-drivers that referenced this issue Dec 5, 2023
If ProDOS finds a ThunderClock it installs a built-in driver for it.
The ThunderClock card gives day-of-week but not year. So the driver
uses the day/month/day-of-week to infer the year, using a 7-entry
table. This means the driver gives the wrong year unless it is
reasonably updated.

ProDOS 2.4.2 includes an update to handle 2018-2023 but that's about
to run out. ProDOS-8/ProDOS8-Testing#72

Make the CLOCK.SYSTEM jumbo driver do the extra work of updating the
year table for the ThunderClock driver. This handles old versions of
ProDOS from 1.1 through 2.4.2, and the update handles 2023 through
2028. (In 2027 we can update again to handle through 2032.)
@JohnMBrooks
Copy link

Fixed in 2.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants