Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vite build warnings #17

Closed
ddeboer opened this issue Sep 15, 2021 · 2 comments
Closed

Fix Vite build warnings #17

ddeboer opened this issue Sep 15, 2021 · 2 comments

Comments

@ddeboer
Copy link
Contributor

ddeboer commented Sep 15, 2021

When building the SCSS with Vite (https://github.com/ProDemos/pas-ui/pull/269), some warnings are thrown:

vite v2.5.4 building for production...
transforming (223) node_modules/crypto-js/core.jsWARNING: You probably don't mean to use the color value transparent in interpolation here.
It may end up represented as transparent, which will likely produce invalid CSS.
Always quote color names when using them as strings or map keys (for example, "transparent").
If you really want to use the color value here, use '"" + $cname'.

    ╷
227 │         &.#{$cname} {
    │             ^^^^^^
    ╵
    node_modules/@prodemos/pds/assets/sass/pds/components/_icon.scss 227:13  @import
    node_modules/@prodemos/pds/assets/sass/main.scss 43:9                    @import
    src/App/sass/main.scss 7:9                                               @import
    src/App.vue 4:13                                                         root stylesheet

@commonpike
Copy link
Contributor

@ddeboer - fixed that - can you look at https://github.com/ProDemos/pds/pull/19/files ? it seems I couldn't create a new package using semantic release, and that should fix it. did I do that correctly ?

see https://github.com/ProDemos/pds/runs/3650979941 ...

@ddeboer
Copy link
Contributor Author

ddeboer commented Sep 20, 2021

The release was successful, so you should be able to upgrade PAS-UI to that.

@ddeboer ddeboer closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants