Linestring visualisation support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostProRail
requested review from
PR-Maik,
OscarOnTrack,
oscarvhees and
luukschuurmansprorail
as code owners
This was
linked to
issues
Mar 25, 2022
Closed
PR-Maik
previously approved these changes
Mar 25, 2022
Also add documentation
PR-Maik
previously approved these changes
May 6, 2022
PR-Maik
previously approved these changes
May 6, 2022
Nozziel
previously approved these changes
May 6, 2022
openspoor/visualisations/trackmap.py
Outdated
| :return: A GeoPandas dataframe. | ||
| """ | ||
| # TODO: use pandas to geopandas functionality? | ||
| print(file) |
There was a problem hiding this comment.
looks like a debugging leftover?
There was a problem hiding this comment.
Correct, removed!
| self.superfigure = folium.Figure(1000, 400) | ||
| self.add_to(self.superfigure) | ||
| return self.superfigure | ||
| else: | ||
| return self | ||
|
|
||
| def save(self, save_name: Path): | ||
| """ |
There was a problem hiding this comment.
4 spaces tabs.. thats not PEP8 :-)
There was a problem hiding this comment.
This happens throughout the whole repo, left as is for now. Will note this as an issue.
added 2 commits
May 6, 2022 11:28
…-DataLab/openspoor into linestring_visualisation_support
PR-Maik
approved these changes
May 6, 2022
Nozziel
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.