Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests and dependencies #1

Merged
merged 3 commits into from Jul 21, 2017
Merged

Update tests and dependencies #1

merged 3 commits into from Jul 21, 2017

Conversation

lliss
Copy link
Contributor

@lliss lliss commented Jul 5, 2017 •
edited

We were having trouble getting this to run in new docker containers. This change aims to address these issues by ensuring we can build the project with new dependencies, and that tests continue to pass. Minor code adjustment addresses changes in restify and moves us to strict mode for more of our modules.

To test

  • Pull repo to your probo vm
  • npm install
  • run tests
  • ensure they pass.

@coveralls
Copy link

coveralls commented Jul 5, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 73dbc3d on fix/lliss/tests into 3f9c2ac on master.

@lliss lliss changed the title Update travis.yaml file and dependencies. Update tests and dependencies Jul 5, 2017
@lliss lliss requested review from tortillaj and sk33lz July 5, 2017 20:45
@ProboCI ProboCI deleted a comment from coveralls Jul 5, 2017
@ProboCI ProboCI deleted a comment from coveralls Jul 5, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2b940fb on fix/lliss/tests into 3f9c2ac on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2b940fb on fix/lliss/tests into 3f9c2ac on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2b940fb on fix/lliss/tests into 3f9c2ac on master.

@lliss lliss merged commit 268f364 into master Jul 21, 2017
@lliss lliss deleted the fix/lliss/tests branch July 21, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortillaj tortillaj Awaiting requested review from tortillaj

@sk33lz sk33lz Awaiting requested review from sk33lz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lliss @coveralls