Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the log channel via settings.
It defaults to the shared instance, but framework consumers will be able to implement their own
LogChannel
and set it using:Removes
system
log (which used a private log writer)This will allow framework consumers to re-direct all logging through a central log channel/writer/formatter as they wish. This means, that framework consumers can use the default
Log.Channel
instance, but could set a special log writer, for example:which is equivalent of:
For platforms which support
OSLog
Added an API to use the default LogWriter (
Log.Writers.OSLogWriter
) but with a given instance ofOSLog
- this will allow framework consumers to setup the log using their own subsystem and category. Unfortunately, at this time, we can only use a single OSLog instance. It is recommended that app developers create aOSLog
instance dedicated for ProcedureKit and use their bundle ID as the subsystem, and "ProcedureKit" as the category.Created following discussions in #899
So, for example, it's now possible to do this: