Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements pools #29

Merged
merged 24 commits into from
Nov 14, 2018
Merged

Implements pools #29

merged 24 commits into from
Nov 14, 2018

Conversation

chipit24
Copy link
Contributor

Related issue: #2. Note: This PR only implements pool functionality; lanes will come in another PR.

  • If there are currently elements on the page but no pools, dragging a pool onto the page will move all elements into the new pool.
  • Dragging elements around in the pool will expand the pool.
  • If there are pools on the page, elements must be dragged onto the pool, otherwise it won't be added to the diagram.

What's currently not working:

  • Parsing pools in XML ("Upload XML").
  • Dragging elements between pools (currently just expands the pool).

Copy link
Contributor

@tdondich tdondich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot link elements inside pools. I tried a start event and a task in a pool and then tried to connect the start to the task.

 * Ensure pool elements are property cleaned up when parent pool is removed.
@tdondich
Copy link
Contributor

After deleting a pool, I can no longer drag items over the canvas.

Steps to reproduce:

  • Create a pool
  • Drag start event into pool
  • Delete start event
  • Delete pool
  • Attempt to drag control into canvas

@velkymx
Copy link
Contributor

velkymx commented Nov 2, 2018

I need to be able to resize the pool to add new elements.

@chipit24
Copy link
Contributor Author

chipit24 commented Nov 6, 2018

I need to be able to resize the pool to add new elements.

@velkymx Currently, the pool expands when you drag an element near the edge, but this functionality will be modified (to allow dragging elements between lanes and pools). But I will make it so pools and lanes will still resize if you drag elements near the edge.

Resizing elements sounds like a task that should be handled in a different PR (and possibly different issue), to:

  • Cut down on merge conflicts.
  • Keep PRs smaller for quicker review and merge.
  • More easily track progress.

@chipit24 chipit24 added the WIP Work in progress; do not merge yet. label Nov 6, 2018
@tdondich
Copy link
Contributor

tdondich commented Nov 9, 2018

@chipit24 appears to be an issue. Reproduction steps:

  • Drag a start event
  • Drag a pool. Start event properly goes into initial lane of pool
  • Create the lane crown element to create a new lane
  • click on lane start event is in
  • Notice start event is no longer visible

@chipit24 chipit24 removed the WIP Work in progress; do not merge yet. label Nov 9, 2018
@chipit24 chipit24 mentioned this pull request Nov 13, 2018
@tdondich tdondich merged commit dfaeea6 into develop Nov 14, 2018
@JCook21 JCook21 deleted the feature/2 branch September 4, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants