Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-4579: Removed force password change from profile edit #4164

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

agustinbusso
Copy link
Contributor

Issue & Reproduction Steps

This PR removes the option User must change password at next login on edit profile view. Now is only available in edit user view.

Solution

  • Added a condition to show or not the control depending of the URL

How to Test

  • First login with an admin user and go to some user edit. The toggle should be available under login information section.
  • Then go to the profile and edit profile. The option should not be available.

Working video

Screen.Recording.2021-11-19.at.09.32.33.mov

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@pmkerberos
Copy link

QA server was successfully deployed https://bugfix-four-4579-processmaker.ci.processmaker.net

@eiresendez eiresendez self-requested a review November 19, 2021 21:46
Copy link
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The toggle is correctly removed from the profile/edit view. I did the tests manually.

@eiresendez eiresendez merged commit b4e9cbe into develop Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants