Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FOUR-4843 - Conditional Start Event does not work with manual and subprocess #4241

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

eiresendez
Copy link
Contributor

Issue & Reproduction Steps

In release.testing.processmaker.net server was using an "old" process "Regression 4.2.24 Start Event". This process generated a "MySQL 22001 Right truncation data exception" error when trying to update the global_variables table.

For this reason, no new Requests were generated from the Conditional Start Event.

  1. Design a process conditional start event -> manual or subprocess -> end event. Or import the attached processes.
  2. Set up process condition date('d')%2==0) or date('d')%2==1) .
  3. Run on Tinker:
for ($i=0; $i<1500; $i++) { \Artisan::call('bpmn:timer'); }

In that way you will get the MySQL error.

Solution

  • Remove the cache key at the moment the MySQL error is generated. So it can continue working after.

How to Test

  1. Replicate the MySQL error locally.
  2. Run php artisan bpmn:timer

The record in the DB will be removed and the expected behavior will be obtained: Request must be created with the conditional start event.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@pmkerberos
Copy link

QA server was successfully deployed https://bugfix-four-4843-4-2-processmaker.ci.processmaker.net

@ryancooley ryancooley merged commit b46f506 into develop Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants