Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Fix missing data evaluating Data connector #4255

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

marcoAntonioNina
Copy link
Contributor

Issue & Reproduction Steps

Data connector task does not save the information the outbound configuration.

  1. Create a collection
  2. Add end-point with method post and configure body parameters
  3. Create a process with Data-connectors
  4. Configure parameter of body in data-connector in the task

Note: Do not use the same variable names, use different like:

Parameter Value
doctorName {{form_input_1}}
doctorID {{form_input_2}}

and in the DataSource POST body, something like:

{
  "data": {
    "id": "{{doctorID}}",
    "name": "{{doctorName}}"
  }
}

Solution

  • Merge request data and params values.

How to Test

Run a process with data source.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@marcoAntonioNina marcoAntonioNina changed the title Fix missing data evaluating Data connector [4.1] Fix missing data evaluating Data connector Jan 24, 2022
@pmkerberos
Copy link

QA server was successfully deployed https://bugfix-four-4333-a-processmaker.ci.processmaker.net

@ryancooley ryancooley merged commit f7f1f05 into 4.1-develop Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants