Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellucian/check logs changes #4259

Merged
merged 8 commits into from Jan 28, 2022
Merged

Ellucian/check logs changes #4259

merged 8 commits into from Jan 28, 2022

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Jan 26, 2022

Issue & Reproduction Steps

  • In DataSources response is removed even if it is mapped
  • Mustache helpers: json, serialize, xml are not working
  • Comments subscriber is throwing errors when getting the request ID
  • Can not see malformed URL in data sources
  • Data source is merging the body response with headers
  • When process throws a Signal, the Job serializes all the data, it cause a Redis overflow when request data is huge

Solution

  • Fix remove response and status from default response (requires: https://github.com/ProcessMaker/package-data-sources/pull/216)
  • Fix Mustache helpers: json, serialize, xml are not working
  • Fix Comments subscriber getting the request ID
  • Add a visible Http Exception when URL is invalid
  • The response contains the body content
  • Pack the signal data when Job is dispatched

How to Test

Run the Ellucian Synchronization Process.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@pmkerberos
Copy link

QA server was successfully deployed https://ellucian-check_logs_changes-processmaker.ci.processmaker.net

@pmkerberos
Copy link

QA server was successfully deployed https://ellucian-check_logs_changes-processmaker.ci.processmaker.net

@caleeli caleeli marked this pull request as ready for review January 28, 2022 14:04
@ryancooley ryancooley merged commit caab460 into develop Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants