Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Data Input Read Only #4327

Merged
merged 2 commits into from Apr 13, 2022
Merged

Fix Data Input Read Only #4327

merged 2 commits into from Apr 13, 2022

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Apr 6, 2022

Issue & Reproduction Steps

Ticket FOUR-5893

  1. Create a screen
  2. Add Line Input control
  3. click preview
  4. In the data input editor try to edit the data

Expected Behavior
Should be able to edit the data input on the screen.

Current Behavior
Can not edit the data input on the screen.

Solution

The issue was due to the Data Input and Data Preview monaco editors sharing the same options set in the monacoOptions variable which had readOnly set to true.

Solution is to remove the readOnly option from the monacoOptions.

How to Test

Test the above steps above and ensure the Data Preview editor is read only.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@pmkerberos
Copy link

QA server was successfully deployed https://bugfix-four-5893-processmaker.ci.processmaker.net

@sanjacornelius sanjacornelius removed the WIP label Apr 6, 2022
@pmkerberos
Copy link

QA server was successfully deployed https://bugfix-four-5893-processmaker.ci.processmaker.net

1 similar comment
@pmkerberos
Copy link

QA server was successfully deployed https://bugfix-four-5893-processmaker.ci.processmaker.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants