Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-6307 DevDependencies that should be Dependencies and vice-versa #4390

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

josechirivella
Copy link
Contributor

@josechirivella josechirivella commented May 24, 2022

Issue & Reproduction Steps

https://processmaker.atlassian.net/browse/FOUR-6307

  • Also. Removed the coverage folder since it was being committed for some reason while testing jest but not fixing jest in this ticket

Solution

  • Moved the dependencies to the corrective places and removed some dependencies that needed be to be listed

How to Test

Just make sure you can install the dependencies without any errors and compile the app without any issues and that the app runs without any issues

Related Tickets & Packages

  • Link to any related FOUR tickets, PRDs, or packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@josechirivella josechirivella changed the title FOUR-6307 FOUR-6307 DevDependencies that should be Dependencies and vice-versa May 24, 2022
@ryancooley ryancooley merged commit 6635b56 into FOUR-6080 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants