Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/FOUR-6178: Web Entry Custom URLS #4393

Merged
merged 20 commits into from
Jun 14, 2022

Conversation

agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented May 26, 2022

Please read the PRD FOUR-6178

NOTE: Custom URL for web entries are only available for start event web entries

How to Test

  • Create some processes with web entry start events.
  • Click the new Options button under web entry URL
  • A modal should open with all the configuration fields for custom webentries URL
  • Test first segment is unique
  • Add some parameters like state, city
  • Copy the url, in the parameters section you should have something like /{state}/{city}
  • Paste the URL in the web browser and replaze the variables {state} and {city} for some param like /nevada/las-vegas
  • The form for the web entry should show.
  • Complete the form and go to requests
  • Check in the request data tab, you should see 2 new attributes in the data object "state" and "city", with the values entered in the URL input of the browser.

Also test web entry is working without custom params

Working video

With custom params

Screen.Recording.2022-05-26.at.15.47.19.mov

Without custom params

Screen.Recording.2022-05-26.at.15.49.58.mov

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@agustinbusso
Copy link
Contributor Author

Change between standard and custom url

webentry-change-between-standard-custom-url.mov

Check param data is in request data tab

webentry-check-paramdata.mov

Check web entry import/export. If route exists allows to change it

webentry-export-import.mov

Check web entry custom URL works with segment and no parameters

webentry-no-params.mov

Check web entry custom URL works with segment and one parameter

webentry-one-param.mov

Check web entry custom URL works with segment and more than one parameter

FAILING

webentry-two-or-more-params.mov

Check web entry custom URL works with query strings

webentry-querystring-custom-url.mov

Check web entry standard URL works with query strings

webentry-querystring-standard-url.mov

Check web entry works when back to standard URL

webentry-works-also-when-back-to-standard-url.mov

Check web entry segment is available for other processes after back to standard URL

webentry-segment-available-when-back-to-standard-for-other-processes.mov

Check web entry custom URL works with authenticate method

webentry-work-with-authenticate-method.mov

Check web entry custom URL works with SSO authenticate method

webentry-sso-auth.mov

Check web entry segment is available for same process after back to standard URL

FAILING

webentry-segment-available-when-back-to-standard-for-same-process.mov

UPDATED WORKING VIDEO

webentry-segment-available-same-process.mov
  • Show options button only in start event web entries
  • Select between standard or custom url
  • Disable elements when Standard URL is selected
  • Save web entry configuration
  • Show web entry custom url in inspector
  • Web entry custom url export import. If route exists, allows to replace it
  • After disable custom url web entry, segment should be available in other processes
  • Check param data is in request data tab
  • Check more than one param data is in request data tab
  • Check is working with query string in standard url
  • Check is working with query string in custom url
  • Check web entry custom URL works with segment and no parameters
  • Check web entry custom URL works with segment and one parameter
  • Check web entry custom URL works with authenticate method
  • Check web entry custom URL works with SSO authenticate method
  • Check web entry custom URL works with segment and more than one parameters
  • After disable custom url web entry, segment should be available in same process

@ryancooley ryancooley changed the base branch from develop to 4.2.31-RC1+patch-1-cartegraph June 14, 2022 17:33
@ryancooley ryancooley merged commit 634ebb6 into patch-1-cartegraph Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants