Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FOUR-6006 - Warnings are displayed when running scripts breaking script execution #4417

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

eiresendez
Copy link
Contributor

@eiresendez eiresendez commented Jun 16, 2022

Issue & Reproduction Steps

Warnings are displayed when running scripts breaking script execution

  1. Create a new script
  2. Use the following code:
$apiInstance = $api->tasks();
$result = $apiInstance->getTasks();
return $result;
  1. Run the Script

Solution

  • If the type is not defined it is set to "string" by default. That causes settyype problems. The solution is to explicitly set the type of the property.

How to Test

  • Rebuild the PHP Executor at /admin/script-executors.
  • Follow the steps of above.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link
Contributor

@mcraeteisha mcraeteisha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ryancooley ryancooley merged commit 6b3ef75 into develop Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants