Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-6432: 4.2.31-Adjust upgrade migration that updates each username based on a list of disallowed not to sanitize the #4418

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

danloa
Copy link
Contributor

@danloa danloa commented Jun 20, 2022

Issue & Reproduction Steps

Keeps @ + . - _ characters in user names when the migration that fixes user names is run

Solution

  • Added the allowed characters in the regular expressions

How to Test

Add users that use not allowed characters and allowed characters, for example
user1.lastname1
user2@lastname2
user3_lastname3
user4-lastname4
user5+lastname5
user6~lastname6
user7 lastname7
user8*lastname8
user9^lastname9

After the upgrade the user names should be modified to (not allowed characters must be removed):
user1.lastname1
user2@lastname2
user3_lastname3
user4-lastname4
user5+lastname5
user6lastname6
user7lastname7
user8lastname8
user9lastname9

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-6432

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@ryancooley ryancooley merged commit 30097a2 into develop Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants