Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-6466: Web entry timeout redirect in Cartegraph instances (cartegraph) #4438

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

danloa
Copy link
Contributor

@danloa danloa commented Jul 11, 2022

Issue & Reproduction Steps

Create an Anonymous Web Entry. Wait until the session timeout time happens.

Solution

  • A new property that determines if a webentry is anonymous or not has been added to the model
  • To set the time out this property isAnonymous sets a header to enable/disable the time out control

How to Test

Create an Anonymous Web Entry. Wait until the session timeout time happens and verify that the pages is not redirected to the login page.
To speed up the test, change the default session time out in .env or editing config/session.php to something like
'lifetime' => env('SESSION_LIFETIME', 10)
that is 10 minutes by default.

Test with embedded and not embedded web entries and with web entries in start events and tasks.

The attached zip file has a process with the 4 combinations. Put the html files in processmaber/public to open them directly in the browser (e.g. http://server/embedded_auth_start.html)

webentry.zip

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-6466
PR for webentry: https://github.com/ProcessMaker/package-webentry/pull/153

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@danloa danloa marked this pull request as ready for review July 11, 2022 15:50
Copy link
Contributor

@agustinbusso agustinbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for all scenarios:

Anonymous start event webentry and embeded webentry should not redirect

Screen.Recording.2022-07-11.at.17.17.21.mov

Anonymous task webentry and embeded webentry should not redirect

Screen.Recording.2022-07-11.at.17.19.05.mov

Auth task webentry and embeded webentry should redirect

Screen.Recording.2022-07-11.at.17.23.08.mov

Auth start event webentry and embeded webentry should redirect

Screen.Recording.2022-07-11.at.17.29.09.mov

@ryancooley ryancooley merged commit e033c77 into patch-1-cartegraph Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants