Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FOUR-6398 "Setup User" and "User Setup Signal Throw" are displayed under All Requests #4487

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

eiresendez
Copy link
Contributor

@eiresendez eiresendez commented Aug 30, 2022

Issue & Reproduction Steps

The "Setup User" and "User Setup Signal Throw" requests from previously executed runs of Ethos User Sync are now viewable under All Requests.

  1. Create or locate a System Process.
  2. Generate a request from that Process.
  3. Delete the Process from step 1.

Solution

  • The scope withTrashed was added, to take into account soft-deleted processes so we can correctly filter system requests.

How to Test

Follow the reproduction steps of above. You should not see system requests at /requests page.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

test with 'single' quotes

@ryancooley ryancooley merged commit 0d63d4e into develop Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants