Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 10 Upgrade #5168

Merged
merged 69 commits into from Aug 29, 2023
Merged

Laravel 10 Upgrade #5168

merged 69 commits into from Aug 29, 2023

Conversation

nolanpro
Copy link
Collaborator

@nolanpro nolanpro commented Aug 16, 2023 •
edited

Issue & Reproduction Steps

See https://processmaker.atlassian.net/browse/FOUR-9714

Laravel upgrade from 8 to 9 to 10

Solution

  • Upgrade core Laravel packages and dependencies
  • Make required changes to core and PM packages
  • Use php 8.2

How to Test

  • Use php 8.2
  • Smoke test the app
  • List of specific changes to test TBD

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-7194

Packages
https://github.com/ProcessMaker/connector-docusign/pull/36
https://github.com/ProcessMaker/connector-send-email/pull/263
https://github.com/ProcessMaker/docker-executor-node-ssr/pull/9
https://github.com/ProcessMaker/package-actions-by-email/pull/118
https://github.com/ProcessMaker/package-collections/pull/360
https://github.com/ProcessMaker/package-data-sources/pull/314
https://github.com/ProcessMaker/package-decision-engine/pull/53
https://github.com/ProcessMaker/package-pm-blocks/pull/84
https://github.com/ProcessMaker/package-savedsearch/pull/378
https://github.com/ProcessMaker/package-sentry/pull/16
https://github.com/ProcessMaker/package-translations/pull/60
https://github.com/ProcessMaker/package-versions/pull/69
https://github.com/ProcessMaker/package-vocabularies/pull/82
https://github.com/ProcessMaker/package-webentry/pull/213
ProcessMaker/pmql#35

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:connector-send-email:feature/FOUR-9714
ci:docker-executor-node-ssr:feature/FOUR-9714
ci:package-webentry:feature/FOUR-9714
ci:package-savedsearch:feature/FOUR-9714
ci:package-data-sources:feature/FOUR-9714
ci:package-sentry:feature/FOUR-9714
ci:package-translations:feature/FOUR-9714
ci:pmql:feature/FOUR-9714
ci:package-pm-blocks:feature/FOUR-9714
ci:package-actions-by-email:feature/FOUR-9714
ci:package-collections:feature/FOUR-9714
ci:connector-docusign:feature/FOUR-9714
ci:package-decision-engine:feature/FOUR-9714
ci:package-vocabularies:feature/FOUR-9714
ci:package-versions:feature/FOUR-9714

ci:deploy
..

laravel-shift and others added 30 commits August 8, 2023 18:14
@laravel-shift
Apply code style
cc6ac98
@laravel-shift
Move resources/lang folder
cbb8798
@laravel-shift
Remove fruitcake/laravel-cors dependency
9574ad0
@laravel-shift
Upgrade to Flysystem 3.0
bcdefd6
@laravel-shift
Shift core files
d6d8955
@laravel-shift
Convert optional() to nullsafe operator
78b3dea
@laravel-shift
Use Faker methods
bb50285 
Accessing Faker properties was deprecated in Faker 1.14.
@laravel-shift
Adopt class based routes
adfe498
@laravel-shift
Shift config files
39a2986
@laravel-shift
Default config files
89f9e4f 
In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.
@laravel-shift
Bump Laravel dependencies
3d2d9b3
@laravel-shift
Set return type of base TestCase methods
aefa3ff 
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type:

- `setUpBeforeClass()`
- `setUp()`
- `assertPreConditions()`
- `assertPostConditions()`
- `tearDown()`
- `tearDownAfterClass()`
- `onNotSuccessfulTest()`

[1]: https://phpunit.de/announcements/phpunit-8.html
@laravel-shift
Adopt anonymous migrations
d47628c
@laravel-shift
Shift cleanup
d97bd1f
@pmoskrojas
Fix Language Resources issues after upgrade with Laravel Shift
005f043
@pmoskrojas
Solving unittest issues and libraries upgrade manual method
da6ca18
@pmoskrojas
Delete composer.json
7c80295
@pmoskrojas
Update composer.json
79908d3
@pmoskrojas
Update package.json with new versions of Axios and Laravel Echo Serve…
2bb95f7 
…r to solve vulnerabilities
@nolanpro
Update composer lock
136f465
@nolanpro
Put back package name
49c5778
@nolanpro
Update .gitignore
9e32fbf
@nolanpro
Merge branch 'next' into shift-97359
6e13095
@nolanpro
Remove package from composer.json
4782fd2
@nolanpro
Revert "Move resources/lang folder"
509e7a9 
This reverts commit cbb8798.
@nolanpro
Keep original from email address
ef6c60f
@nolanpro
Use original package.json
91312b4
@estebangallego @nolanpro
Move failing migration to upgrades
70abb7d
@nolanpro
Use legacy output formatting
3d5b3c2
@nolanpro
Merge branch 'next' into shift-97359
6b5ad1f
@nolanpro
Remove deprecated event assertions
5e7b9bd
@nolanpro
Revert "Move resources/lang folder"
befb5e9 
This reverts commit 82f3a25.
@nolanpro
Call job handler directly when a return value is needed
dd957f6
@nolanpro
dispatchSync requires all props to be defined
d6d0c0e
@nolanpro
Do not queue an app re-binding when migrating for tests
48659b0
@nolanpro
Bus fake must include RefreshArtisanCaches
99fc564
@nolanpro
Log records are now monolog objects
925b87e
@nolanpro
Remove Laravel-specific translations
b398dec
@nolanpro
Ignore Laravel-specific language files
fb66839
@nolanpro
Update Laravel-specific language files
1321f7e
@nolanpro
Use php 8.2
9b656d1
@nolanpro
Fix deprecated syntax
0651664
@nolanpro
Specify base image
060aff7
@nolanpro
Fix tests related to language file updates
0fe799d
@nolanpro
Use request->merge
550ce86
@nolanpro
Merge pull request #5169 from ProcessMaker/shift-97938
144cb89 
Laravel 10.x Shift
@nolanpro
Merge branch 'next' into feature/FOUR-9714
0c03f23
@nolanpro
Skip saved search user defaults in tests
11c0445
@nolanpro nolanpro mentioned this pull request Aug 24, 2023
Merged
@tokensPM
Copy link

QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net

@gustavobascope gustavobascope self-requested a review August 25, 2023 21:33
gustavobascope
gustavobascope approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@gustavobascope gustavobascope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a smoke test of the main functionalities

@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition C Reliability Rating on New Code (is worse than A)
Failed condition 13.3% 13.32% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@tokensPM
Copy link

QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net

3 similar comments
@tokensPM
Copy link

QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net

@tokensPM
Copy link

QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net

@tokensPM
Copy link

QA server was successfully deployed https://ci-0dc9988931.eng.processmaker.net

@ryancooley ryancooley merged commit cb7109d into next Aug 29, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavobascope gustavobascope gustavobascope approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@nolanpro @tokensPM @gustavobascope @ryancooley @laravel-shift @pmoskrojas @estebangallego