Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot export a previously imported process containing a script with a missing script executor #5173

Merged
merged 2 commits into from Aug 18, 2023

Conversation

marcoAntonioNina
Copy link
Contributor

@marcoAntonioNina marcoAntonioNina commented Aug 17, 2023

Issue & Reproduction Steps

Currently exporting a ScriptExecutor was not enabled, for that reason when you have Custom ScriptExectors it is not reflected on the import on a new server

Solution

Just enabled the option, and added a fix to continue if a ScriptExecutor doesn't exist.

Also added the BuildScriptExecutor when creating or updating a ScriptExecutor.

How to Test

Create a script executor that exists like PHP or another language
Create a Script with the script executor
Create a process with a script task
Publish the changes
Export the process
Import the process in a new instance the PM
Try to export the process

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link
Contributor

@agustinbusso agustinbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When exporting a process with a new existing script executor into a new instance the changes fixes the issue

Screen.Recording.2023-08-17.at.16.36.53.mov

Copy link
Contributor

@agustinbusso agustinbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes working as expected for the following use cases:

  • If an executor does not exists in the new env, after import, it will created the new executor
  • If an executor does exists in the new env, after import, it will update the existing executor
Screen.Recording.2023-08-18.at.09.34.13.mov
Screen.Recording.2023-08-18.at.09.32.16.mov

@ryancooley ryancooley merged commit 8499b68 into develop Aug 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants