Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-10079: We get a Request aborted message when we want to create a process from AI in fire fox #5201

Merged
merged 1 commit into from Aug 25, 2023

Conversation

agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented Aug 24, 2023

Issue & Reproduction Steps

The problem happens in firefox when a request is aborted. If the user clicks on the button Generate process using AI before the templates request finished it shows a Request abort message.

Steps to Reproduce:

  • Log in with Fire Fox browser
  • Click on +PROCESS
  • click on Generate from text

NOTE: If you can't reproduce the issue, add in TemplateController.php in the index method the following code to simulate a slow request:

if ($type === 'process') { sleep(10); }

Solution

  • Do not show the error messages related to ECONNABORTED.

How to Test

  • Follow steps above

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

@tokensPM
Copy link

QA server was successfully deployed https://ci-840af9def7.eng.processmaker.net

@estebangallego estebangallego self-requested a review August 24, 2023 21:18
Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ryancooley ryancooley merged commit 64a0644 into develop Aug 25, 2023
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants