Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-10223: Publish button and Top Menu elements on Script Editor now visible after Ai Assistant actions #5226

Merged
merged 1 commit into from Sep 1, 2023

Conversation

TinCodes
Copy link
Contributor

@TinCodes TinCodes commented Aug 30, 2023

Issue & Reproduction Steps

  1. Login as admin
  2. Go to Designer
  3. Click on Scripts
  4. Click on +Script
  5. Set the information required
  6. Click on Cornea AI Assistant
  7. Click on Any option and generate

Solution

By modifying the v-if that hides the Top Menu and replacing it with a v-show the destruction of that component is avoided. The problem was caused because package-versions only included the Publish button and other elements once and would not do it again when the Top Menu component was destroyed and recreated.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@agustinbusso agustinbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct

Screen.Recording.2023-08-30.at.17.37.06.mov

@tokensPM
Copy link

QA server was successfully deployed https://ci-b247b25601.eng.processmaker.net

@ryancooley ryancooley merged commit 3bfde25 into next Sep 1, 2023
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants