FOUR-10287: Changing a setting while routes are cached causes fatal exception

[runyan-co]

Issue & Reproduction Steps

1. Cache the routes with APP_RUNNING_IN_CONSOLE=false php artisan route:cache
2. Go to the admin dashboard, then settings and change one of the settings (e.g. turn on a user signal)
3. Refresh one or two times and notice the fatal error:

Symfony\Component\Routing\Exception\RouteNotFoundException
Route [package.comments.index] not defined.

Solution

• Remove an unnecessary artisan call to re-cache the routes after the setting(s) are updated. Since this artisan call would've been run without APP_RUNNING_IN_CONSOLE=false set as an environment variable, it fails to cache all routes and causes a fatal error for any HTTP request sent after.

How to Test

You should now be able to update any setting with the config or routes cached without any fatal errors occuring when sending a HTTP request to the app.

Related Tickets & Packages

• FOUR-10287

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[processmaker-sonarqube]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication