Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-10027 | Develop Asset Addition, Duplication, and Delete Confirmation Modals #5245

Merged
merged 5 commits into from Sep 1, 2023

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Sep 1, 2023

Issue

Ticket: FOUR-10027

Develop Modals for Asset Addition, Duplication, and Deletion.
Create Ellipsis Menu with Search Bar for Add Asset Dropdown.

How to Test

  1. Go to branch feature/FOUR-10027 in processmaker.
  2. Go to branch feature/FOUR-10027 in package-projects. Install the package.
  3. Go to Designer → Projects. Have a Project created and Assets associated to the project.
  4. Open a Project. Click on +ASSET.
    • There should be an Ellipsis Menu with different types of Assets to add.
    • There should be a search bar on the Ellipsis Menu.
      NOTE: Search bar functionality is not completed.
    • Clicking on an Asset in the Ellipsis Menu should display a 'Create {Asset Type}' Modal.
  5. Click on the Ellipsis Menu for one of the Assets in your Project.
    • Clicking the 'Duplicate' button should display a 'Duplicate {Asset Type}: {Asset Name}' Modal.
      • The name of the Asset should prefill with 'Copy' added to the end of the name.
    • Clicking the 'Remove' button should display a 'Remove Asset' Modal.

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryancooley ryancooley merged commit b936a85 into next Sep 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants