Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-10284 | We Need ‘data-test’ or ‘data-cy’ Attributes on Components #5249

Merged
merged 1 commit into from Sep 2, 2023

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Sep 1, 2023

Issue

Ticket: FOUR-10284

We need to add data-test or data-cy attributes to the following components:

  • Ellipsis Menu of Projects
  • Ellipsis Menu of Project Categories
  • ADD Button in Add New Project Modal
  • IMPORT Project Button
  • Member Select in Add New Project Modal
  • Category Select in Add New Project Modal
  • Name Input in Add New Project Modal
  • Project Search in Project Listing

How to Test

  1. Go to branch feature/FOUR-10284 in processmaker.
  2. Go to branch feature/FOUR-10284 in package-projects.
  3. Go to each of the elements listed above. Inspect each element to ensure it has a data-cy or data-test attribute.

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ryancooley ryancooley merged commit bfcd222 into next Sep 2, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants