Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-10388: CI Unit Test failing when we sync-pm-blocks #5267

Merged
merged 6 commits into from Sep 7, 2023

Conversation

estebangallego
Copy link
Contributor

@estebangallego estebangallego commented Sep 6, 2023

Issue & Reproduction Steps

An issue arises when the CI executes php artisan package-pm-blocks:sync-pm-blocks and this action triggers an error. Furthermore, if the UUID does not exist within the pm_blocks_category, it results in another error.

How to replicate

  • Checkout to the next branch on Core, PmBlocks and Package Projects
  • Install the PmBlocks Package. (uuid error may occur at this time)
  • Sync the PmBlocks php artisan package-pm-blocks:sync-pm-blocks

Solution

  • Package: Create a migration that will check if the uuid of the category exists.
  • Core: Add a conditional within the ScriptExecutorExporter that will check for an admin user if an authenticated user doesn’t exist.

How To Test

  • Check out the following branches in Core, Pm Blocks and and Package Projects.
    -- bugfix/FOUR-10388
  • Install the Pm Blocks package
  • Install the Package Projects package
  • Sync the PmBlocks php artisan package-pm-blocks:sync-pm-blocks

Related Tickets & Packages

CI

ci:package-pm-blocks:bugfix/FOUR-10388
ci:package-projects:bugfix/FOUR-10388
ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link

@sanjacornelius sanjacornelius modified the milestone: For Review Sep 7, 2023
@ryancooley ryancooley merged commit 43c574c into next Sep 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants