Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add channel access to requester #5274

Merged
merged 1 commit into from Sep 7, 2023
Merged

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Sep 7, 2023

Issue & Reproduction Steps

A webentry interstitial page tries to connect to the created request after a submit, but sometimes it gets denied this is because the channel allowing access to the requester (the user or anon user of a webentry)
This was working on the previous engine because it synchronously creates the start event token that brings access indirectly to the requester.

Solution

  • Give access to the Requester User to the ProcessRequest channel

How to Test

Describe how to test that this solution works.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition D Maintainability Rating on New Code (is worse than A)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@ryancooley ryancooley merged commit 9b473b9 into develop Sep 7, 2023
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants