Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/FOUR-9625: Cleaning code remove unnecessary changes #5279

Merged
merged 1 commit into from Sep 8, 2023

Conversation

pmPaulis
Copy link
Contributor

@pmPaulis pmPaulis commented Sep 7, 2023

Issue & Reproduction Steps

Clean code changes

Solution

  • List the changes you've introduced to solve the issue.

How to Test

Describe how to test that this solution works.

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-9625

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@processmaker-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pmPaulis pmPaulis changed the title FOUR-9625 FOUR-9625: Remove unnecessary changes Sep 7, 2023
@pmPaulis pmPaulis changed the title FOUR-9625: Remove unnecessary changes feature/FOUR-9625: Clean Code remove unnecessary changes Sep 8, 2023
@pmPaulis pmPaulis changed the title feature/FOUR-9625: Clean Code remove unnecessary changes feature/FOUR-9625: Cleaning code remove unnecessary changes Sep 8, 2023
@pmPaulis pmPaulis merged commit 88a2c8e into feature/FOUR-9530 Sep 8, 2023
16 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants