Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/FOUR-10835: AI Search results not rendering correctly - query needs to be resubmitted #5380

Merged
merged 1 commit into from Sep 27, 2023

Conversation

agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented Sep 27, 2023

Issue & Reproduction Steps

1 - use the AI search bar with any query (i.e show all completed requests) and submit
2 - click on the resulting AI link into Requests
3- notice how the list is not actually filtered, even though the search bar does have the right pmql that matches the needed search
4 - click on the pmql search and hit ‘Enter’
5 - only then does the search update to match the original request.

See video in the FOUR ticket

Expected behavior is this should render directly

Solution

  • In the network tab in the browser inspector, two requests were triggered, one by default in vuetable and another in a watcher for the pmql filters. The pmql filters request was ending before than the default request triggered by the datatable. To avoid this race problem a cancel request was added if a new request is triggered.

Working video

Screen.Recording.2023-09-27.at.15.08.09.mov

How to Test

  • Follow steps above.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@processmaker-sonarqube
Copy link

@ryancooley ryancooley merged commit e5e638c into develop Sep 27, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants