Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-12003: Modeler now detects if process was generated by AI #5655

Merged
merged 3 commits into from Nov 23, 2023

Conversation

TinCodes
Copy link
Contributor

@TinCodes TinCodes commented Nov 17, 2023

Issue & Reproduction Steps

The new features for AI Unified Generation need a way to detect if a process was made by AI so that it may suggest to create assets for the new process on Modeler.

Solution

  • Introduced a query string to communicate if the process was generated by the AI Generation tool.
  • Used window.ProcessMaker.modeler global variable to reach the Modeler project and have easy access to the check.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@agustinbusso agustinbusso self-requested a review November 17, 2023 17:25
@@ -286,7 +287,9 @@
const url = `/package-ai/processes/create/${response.data.id}`;
this.$emit("process-created-from-modeler", url, response.data.id, response.data.name);
} else {
window.location = `/modeler/${response.data.id}`;
this.isAiGenerated
? window.location = "/modeler/" + response.data.id + "?ai=1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of one, it can be of Boolean value. Although 1 means true , but you get what I mean

Copy link

@TinCodes TinCodes changed the base branch from next to epic/FOUR-11382 November 23, 2023 19:13
@agustinbusso agustinbusso merged commit 99ce17c into epic/FOUR-11382 Nov 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants