Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/FOUR-12502 The fields are not cleared after closing the modal #5680

Merged
merged 2 commits into from Nov 22, 2023

Conversation

CarliPinell
Copy link
Contributor

Solution

  • Modal window clear all fields on Close

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    ci:deploy

@tokensPM
Copy link

QA server was successfully deployed https://ci-836ac54264.eng.processmaker.net

Copy link

@ana-mauricio ana-mauricio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En esta parte la seleccion de usuario est oculta. SI se cambia el usuario por otro este se queda por defecto y los siguientes scripts seran creados con ese usuario.

El campo user, no se limpia despues que el modal se cierra como se muestra en el video:

simplescreenrecorder-2023-11-22_09.43.08.mp4

@fagubla @pmPaulis

Copy link

@tokensPM
Copy link

QA server was successfully deployed https://ci-836ac54264.eng.processmaker.net

@ana-mauricio ana-mauricio self-requested a review November 22, 2023 15:08
@pmPaulis pmPaulis merged commit 4fa1c34 into feature/FOUR-11496 Nov 22, 2023
6 checks passed
@pmPaulis pmPaulis changed the title QA Observation: Bugfix/FOUR-12502 The fields are not cleared after closing the modal bugfix/FOUR-12502 The fields are not cleared after closing the modal Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants