Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-11846 - Return to Project List After Asset Creation #5681

Merged
merged 12 commits into from Nov 29, 2023

Conversation

eiresendez
Copy link
Contributor

@eiresendez eiresendez commented Nov 21, 2023

Issue & Reproduction Steps

As a user, I want to return to the Project list after creating and publishing a new asset for a Project.

  1. Publish a new asset.
  2. Go back to the Project list.

Solution

  • Reusable code has been implemented to automatically redirect to the project once the assets are published or closed.
  • When creating a new asset from a project and redirecting to the editing interface, a project_id parameter is added to the URL as a reference to return to the original project.

How to Test

  • Test the redirect of the asset for Processes, Scripts, Screens, Data connectors and Decision Tables.

Related Tickets & Packages

ci:next
ci:package-data-sources:task/FOUR-11846
ci:package-projects:task/FOUR-11846
ci:package-decision-engine:task/FOUR-11846

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@tokensPM
Copy link

QA server was successfully deployed https://ci-4e8bbbd66a.eng.processmaker.net

@eiresendez eiresendez marked this pull request as ready for review November 27, 2023 22:28
@eiresendez
Copy link
Contributor Author

We can ignore the Sonarqube warnings, at least for this PR, as the code has been formatted with eslint and is treated as "new code", resulting in those unrelated alerts to the changes in this PR.

@tokensPM
Copy link

QA server was successfully deployed https://ci-4e8bbbd66a.eng.processmaker.net

Copy link

SonarQube Quality Gate

Quality Gate failed

0.0% 0.0% Security Hotspots Reviewed on New Code (is less than 25%)

See analysis details on SonarQube

@ryancooley ryancooley merged commit e76d5a8 into next Nov 29, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants