Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-11378 Loggin and Password improvements #5722

Merged
merged 14 commits into from Dec 1, 2023
Merged

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Nov 30, 2023

Loggin and Password improvements.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

@tokensPM
Copy link

QA server was successfully deployed https://ci-8f094b547b.eng.processmaker.net

Updating feature branch FOUR-11378 with last changes in develop
Copy link

@tokensPM
Copy link

QA server was successfully deployed https://ci-8f094b547b.eng.processmaker.net

@pmPaulis
Copy link
Contributor

@caleeli
I tested is ok but please consider the following behaviour for the UX maybe in other ticket
image
image

Copy link
Contributor

@julceslauhub julceslauhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ryancooley ryancooley merged commit 2323c97 into next Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants