Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Console Error 'response' Undefined in New Process Creation #5751

Merged
merged 1 commit into from Dec 4, 2023

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Dec 4, 2023

This PR resolves a console error 'response' undefined that occurs when attempting to create a new process from the Designer > Processes page.

The issue was due to inconsistent handling of the returned response when storing the new process. The variable response was initially referencing the data object, but within the handling, the variable data was used instead of response, leading to the 'response' undefined error. The solution was to update the variable name from data back to response for consistency.

Solution

  • Updated the variable name from 'data' to 'response' to ensure consistent referencing.

How to Test

  1. Navigate to the Designer > Processes page.
  2. Attempt to create a new process.
  3. Confirm that no console error ('response' undefined) occurs during the new process creation.

Related Tickets & Packages

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@sanjacornelius sanjacornelius changed the base branch from develop to next December 4, 2023 17:47
Copy link

SonarQube Quality Gate

Quality Gate failed

0.0% 0.0% Security Hotspots Reviewed on New Code (is less than 25%)

See analysis details on SonarQube

@ryancooley ryancooley merged commit 28885f1 into next Dec 4, 2023
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants