FOUR-12716: PMQL "lower" function is not working correctly #5779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
The pmql should support the use of the function Lower.
After running the script the error displayed is “SERVER ERROR“. Only if you remove the lower function the pmql works.
Solution
When using a JSON field (
data.example
) and applying the lower function, the following error occurs:This happens because Expression is an object that cannot be directly converted into a string.
This issue likely emerged due to the version upgrade from Laravel 8 to Laravel 10. In Laravel 8, the
__toString()
method existed, but in Laravel 10,this method was removed. Now, to access the value, it is necessary to use the getValue($grammar) method.Documentation for Laravel 10 and 8:
How to Test
Run
php artisan test --filter ExtendedPMQLTest::testLowerFunction
.Related Tickets & Packages
ci:pmql:bug/FOUR-12716
Code Review Checklist