Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle missing classes and columns when importing #5831

Merged
merged 1 commit into from Dec 15, 2023

Conversation

nolanpro
Copy link
Collaborator

@nolanpro nolanpro commented Dec 14, 2023

Issue & Reproduction Steps

See https://processmaker.atlassian.net/browse/FOUR-12929

If a column or class is missing, the import fails.

Solution

  • Log a warning and continue importing

How to Test

Export a simple process from Winter and import it into Fall. The import should complete without errors.

The process table has a new column, case_title. Previously, this was causing it to fail

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

Copy link

Copy link
Contributor

@runyan-co runyan-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @nolanpro!

@tokensPM
Copy link

QA server was successfully deployed https://ci-a23278b474.eng.processmaker.net

@ryancooley ryancooley merged commit 2c056c2 into develop Dec 15, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants