Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve intermittent 422 error in Guided Templates #6034

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Jan 15, 2024

This PR resolves an intermittent 422 error that occurred when running a guided template helper process. The issue was caused by attempting to update a task status to 'completed' through an API request when the task had already been completed.

Solution:

The solution involves checking the task's advanceStatus to ensure that it has not already been marked as completed before making the API request.

How to Test

Note: The issue was encountered on CI servers and could not be replicated locally. However, to test the resolution:

  1. Navigate to Processes -> Guided Templates.
  2. Select a guided template.
  3. Click on 'Get Started' and run through the process.
  4. Ensure that no 422 errors occur.
  5. Upon completion of the guided template, run another guided template.
  6. Confirm that no 422 errors occur.

Related Tickets & Packages

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@sanjacornelius sanjacornelius changed the title WIP: 422 Error Resolve intermittent 422 error in Guided Templates Jan 16, 2024
@eiresendez eiresendez self-requested a review January 16, 2024 18:38
Copy link
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Copy link

processmaker-sonarqube bot commented Jan 16, 2024

@ryancooley ryancooley merged commit c84e70e into next Jan 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants