Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-13248:Processes marked as favorites keep the same label in tooltip #6052

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

fagubla
Copy link
Contributor

@fagubla fagubla commented Jan 17, 2024

Issue & Reproduction Steps

  1. Have to process
  2. Go to Launch Pad
  3. Open a process from cards
  4. Marked as Favorite
  5. Go to the Favorite category
  6. Hover in a process marked as favorite
  7. Check the title of tooltip

Current Behavior
The title for the process in favorite category is incorrect, because these already marked as favorites

Solution

recording.webm

How to Test

Describe how to test that this solution works.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:next

Copy link

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-69e9d391d2.engk8s.processmaker.net

Copy link

@ana-mauricio ana-mauricio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct

  1. Verify with with a simple process without category
  2. Verify with process in two categories
  3. Verify with process in more than tow categoires
  4. Verify with proces restore from archive
    @fagubla

@ryancooley ryancooley merged commit 7cf88cd into next Jan 17, 2024
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants