Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/FOUR-13267 #6061

Merged
merged 6 commits into from
Jan 19, 2024
Merged

bugfix/FOUR-13267 #6061

merged 6 commits into from
Jan 19, 2024

Conversation

luNunezProcessmaker
Copy link
Contributor

@luNunezProcessmaker luNunezProcessmaker commented Jan 18, 2024

Issue & Reproduction Steps

Current Behavior:

Submit does not work correctly

Expected Behavior:

Submit must work correctly

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-13267

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:nexy
ci:deploy

@@ -339,7 +339,7 @@ class="card border-0"
},
submit(task) {
if (this.isSelfService) {
ProcessMaker.alert(this.$t('Claim the Task to continue.'), 'warning');
window.parent.ProcessMaker.alert(this.$t('Claim the Task to continue.'), 'warning');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a method in order to define in one place the this line and only call the method

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmPaulis , Actually ProcessMaker.alert is already a method. With this solution the message will be showed in the Processmaker and not in the frame
cc @luNunezProcessmaker

@luNunezProcessmaker
Copy link
Contributor Author

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-41c1b3a2d2.engk8s.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-41c1b3a2d2.engk8s.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-41c1b3a2d2.engk8s.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-41c1b3a2d2.engk8s.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-41c1b3a2d2.engk8s.processmaker.net

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-41c1b3a2d2.engk8s.processmaker.net

@ryancooley ryancooley merged commit ed297c9 into next Jan 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants