Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-13234: Fix redirect to process after creating process from template #6062

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

runyan-co
Copy link
Contributor

@runyan-co runyan-co commented Jan 18, 2024

Issue

After clicking "Ok" after creating a duplicate process from a process template, the redirect was not functioning.

Reproduction Steps

  1. Create a process from a process template and publish it
  2. Go back to the process templates and create another process from the same process template
  3. Select any of the options on what to do with the assets, "Update", "Keep Previous", or "Duplicate"
  4. Click "Continue"
  5. Select "Yes" for the confirmation box asking "Are you sure you want to proceed with your selection?"
  6. Click "Ok" after the confirmation
  7. Notice you aren't redirected to the process

Solution

  • Fix the conditional that checks if this.redirectTo is set or null

How to Test

Run through the replication steps and this time you should be redirected to the newly created process after clicking "Ok".

Related Tickets & Packages

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @runyan-co
We're having issues with the unitTest. I've added ci:next to the PR and re-run it but no luck.

Copy link

Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ryancooley ryancooley merged commit 3f54cff into next Jan 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants