Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-13995: Incorrect Redirection After Creating ProcessTemplate #6140

Merged
merged 1 commit into from Feb 1, 2024

Conversation

estebangallego
Copy link
Contributor

@estebangallego estebangallego commented Feb 1, 2024

Issue & Reproduction Steps

When initiating a new Process from a Template, if the assets specified in the process already exist within the system, the expected behavior is to redirect the user to the AssetsTable page, where these pre-existing assets should be displayed. Currently, the redirection occurs as expected, but the assets themselves do not appear in the AssetsTable. This issue seems to suggest a loading or retrieval problem where the AssetsTable fails to fetch or render the existing assets in the context of the new Process creation

Solution

  • The problem is related to the use of history.pushState. Redirecting causes these data to be lost.
  • The suggested solution is to use localStorage instead.

How to Test

  • Navigate to Designer->Processes
  • Create a Process from a Template
  • Navigate back to Designer->Processes
  • Create a new Process from the same Template
    When the AssetsTable appears, please ensure that the Assets are been displayed within the table.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

@ryancooley ryancooley merged commit 79d48f7 into next Feb 1, 2024
11 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants