Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observation/FOUR-13973 In processes some columns are not resizing #6141

Merged
merged 7 commits into from Feb 5, 2024

Conversation

gustavobascope
Copy link
Contributor

Issue & Reproduction Steps

In processes some columns are not resizing

Solution

fixed the column attributes and added sorting

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-13973

ci:deploy
ci:next

@tokensPM
Copy link

tokensPM commented Feb 1, 2024

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

@nolanpro nolanpro self-requested a review February 1, 2024 22:39
Copy link
Collaborator

@nolanpro nolanpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavobascope A few things I noticed

  • Can we fix this problem where dragging is causing the text to truncate even when the column is not moving?
column1.mov
  • It seems to cut off more space then necessary. The red boxes are empty space that could be used:
    image

  • Can we fix the background color? It looks like it shifted a few pixels to the right. It should fit inside the grey lines:
    image

@tokensPM
Copy link

tokensPM commented Feb 2, 2024

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

@tokensPM
Copy link

tokensPM commented Feb 2, 2024

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

@gustavobascope
Copy link
Contributor Author

@gustavobascope A few things I noticed

  • Can we fix this problem where dragging is causing the text to truncate even when the column is not moving?

column1.mov

  • It seems to cut off more space then necessary. The red boxes are empty space that could be used:
    image
  • Can we fix the background color? It looks like it shifted a few pixels to the right. It should fit inside the grey lines:
    image

@nolanpro I solved the observations

@tokensPM
Copy link

tokensPM commented Feb 5, 2024

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

Copy link

@tokensPM
Copy link

tokensPM commented Feb 5, 2024

QA server K8S was successfully deployed https://ci-a947944215.engk8s.processmaker.net

@nolanpro nolanpro self-requested a review February 5, 2024 17:23
@nolanpro
Copy link
Collaborator

nolanpro commented Feb 5, 2024

@gustavobascope looks good, thanks!

@ryancooley ryancooley merged commit f09f61a into next Feb 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants