Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL Parameters for Guided Template Modals #6142

Merged
merged 1 commit into from Feb 2, 2024

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Feb 1, 2024

Issue & Reproduction Steps

This PR resolves issues with directing to the guided template modal via URL parameters. The parameters were being removed from the URL when loading, preventing the modal from appearing. The removal of the parameters was due to an outdated conditional that ran on deprecated code.

Solution

The solution is to update the conditional to only remove the parameters when the 'selectCategory' method has an 'undefined' value. This undefined value indicates that the user manually accessed the guided templates and did not load it directly from a URL.

How to Test

  1. Navigate to Processes > Guided Templates.
  2. Select a template.
  3. Copy the URL.
  4. Open a new tab/window.
  5. Paste the copied URL.
  6. Ensure the selected guided template modal appears.

ci:next
ci:deploy

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@tokensPM
Copy link

tokensPM commented Feb 1, 2024

QA server K8S was successfully deployed https://ci-ccc930e2ff.engk8s.processmaker.net

@ryancooley ryancooley merged commit 16c15fa into next Feb 2, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants