Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/FOUR-14002: Designer "Assets" icons default color and hover are not the same as figma #6146

Merged
merged 5 commits into from Feb 2, 2024

Conversation

luNunezProcessmaker
Copy link
Contributor

Issue & Reproduction Steps

Current
The text: Lower camel case

The icon needs to use the color

The mouse over style fill: #1572C2;
image-20240201-222648

Expected
image-20240201-222708

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next
ci:deploy

@tokensPM
Copy link

tokensPM commented Feb 2, 2024

QA server K8S was successfully deployed https://ci-13fac0e9ed.engk8s.processmaker.net

@pmPaulis
Copy link
Contributor

pmPaulis commented Feb 2, 2024

@luNunezProcessmaker
I have the following observations

  1. the letters needs to user the following cs
color: #5E6469;
font-family: "Open Sans";
font-size: 14px;
font-style: normal;
font-weight: 400;
line-height: normal;
letter-spacing: -0.28px;
  1. The styles for the effects New and View are not the same in figma
    image
    image

@tokensPM
Copy link

tokensPM commented Feb 2, 2024

QA server K8S was successfully deployed https://ci-13fac0e9ed.engk8s.processmaker.net

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@tokensPM
Copy link

tokensPM commented Feb 2, 2024

QA server K8S was successfully deployed https://ci-13fac0e9ed.engk8s.processmaker.net

@ryancooley ryancooley merged commit 0619656 into next Feb 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants