Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observation/FOUR-14044: The Log option is showing the categories of data connectors, and the categories tab is not present in the options #6163

Merged
merged 1 commit into from Feb 8, 2024

Conversation

agustinbusso
Copy link
Contributor

@agustinbusso agustinbusso commented Feb 6, 2024

Issue & Reproduction Steps

  • Log in
  • Go to Designer
  • Click on Data Connectors
  • Click on Log options

Current Behavior:
The categories tab in data connectors is not present, and when entering the Logs tab the categories of data connectors are being displayed

Expected Behavior:
The categories tab should be shown in the data options connectors, and the Logs tab should show the logs, not the categories.

Solution

  • Verify permissions and route for data connector and show the correct tags

How to Test

  • Follow steps above.
  • Use different permissions for the user to activate/deactivate different tabs

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@eiresendez eiresendez self-requested a review February 8, 2024 19:10
Copy link
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'Data Connectors', 'Categories', and 'Logs' tabs are properly accessible

@ryancooley ryancooley merged commit ae5ad2d into next Feb 8, 2024
9 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants