Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Observation Bugfix/FOUR-14061: Saved search custom date columns showing wrong date/time #6187

Merged
merged 6 commits into from Feb 8, 2024

Conversation

CarliPinell
Copy link
Contributor

Solution

  • Filters with UTC vonversion were applied to custom columns with datetime and date data type

How to Test

  • Complete a process with date and datetime fields in the screen
  • Add custom date and datetime columns to a saved search.

Related Tickets & Packages

https://processmaker.atlassian.net/browse/FOUR-14061

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.
    ci:deploy
    ci:next

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can try replacing this line when the filter table formats the data on filtertable.vue

watch: {
data() {
this.headers.forEach((column) => {
if (column.format) {
if (column.format === "datetime" || column.format === "date") {
if (this.data?.data?.forEach) {
this.data.data.forEach((element) => {
//element[column.field] = this.formatDate(element[column.field], column.format);
set(element, column.field, this.formatDate(this.getNestedPropertyValue(element, column.field), column.format));
});
}
}
}
});
},
},

Copy link

processmaker-sonarqube bot commented Feb 8, 2024

@ryancooley ryancooley merged commit ad7e1a7 into next Feb 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants